Range Check condition, handle 3rd state "nil"

[mrbuds]

The range check condition test is:
conditionTest = "state and state.show and (UnitExists('target') and WeakAuras.IsSpellInRange(state.spellname, 'target') == 1) == (%s == 1)",

isSpellInRange return
1 if in range
0 if not in range
nil if not applicable

It works good if we test "spell in range" is true
But if we test "spell in range" is false, the nil case is valid for this test which is wrong

[InfusOnWoW]

I guess the correct check would be:
conditionTest = "state and state.show and (UnitExists('target') and WeakAuras.IsSpellInRange(state.spellname, 'target') == %s)"

For which spells does IsSpellInRange return nil?

[mrbuds]

With blackoutkick when i target myself
With Whirling Dragon Punch all the time it return nil

[InfusOnWoW]

Can you test what I suggested?

[mrbuds]

Yes it fix it

[InfusOnWoW]

Good, if you don't beat me to it, I'll do a PR tomorrow.

[InfusOnWoW]

I guess we need something similar for Item ranegs

[mrbuds]

not exactly the same
IsItemInRange return true, false or nil

[InfusOnWoW]

Nice Blizzard!

It looks to me like the existing check should work then