Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Support #91

Merged
merged 25 commits into from
Oct 13, 2021
Merged

Fix macOS Support #91

merged 25 commits into from
Oct 13, 2021

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Oct 10, 2021

  • Save to disk now supports NSSavePanel allowing the user to select a destination
  • MetricKit is not available on macOS (yet) so we had to disable that to allow building on macOS

@AvdLee AvdLee self-assigned this Oct 10, 2021
@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Oct 12, 2021

Messages
📖

View more details on Bitrise

📖 Diagnostics: Executed 19 tests, with 0 failures (0 unexpected) in 0.435 (0.474) seconds

Diagnostics: Coverage: 71.1

File Coverage
MetricsMonitor.swift 16.92%
DiagnosticsReport.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against d4ed6ca

@AvdLee AvdLee merged commit 063da6f into master Oct 13, 2021
@AvdLee AvdLee deleted the feature/macos-support branch October 13, 2021 10:58
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.11.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants