Use latest write APIs to prevent a crash when storage is full. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvdLee
requested review from
amirdew and
kevinrenskers
and removed request for
Boris-Em
Diagnostics.framework: Coverage: 77.11
Generated by 🚫 Danger Swift against 1baffc9 |
amirdew
approved these changes
Jul 21, 2021
|
Congratulations! 🎉 This was released as part of Release 1.9.1 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use the
write(_:)method which has the following documentation:This resulted in several crashes for users which storage was full. With this PR, we fix the crash for users on iOS 13.4 and up which seems good enough for now.