Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charset utf-8 to html head #50

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Add charset utf-8 to html head #50

merged 2 commits into from
Jan 6, 2020

Conversation

intitni
Copy link
Contributor

@intitni intitni commented Jan 3, 2020

Non-ascii characters in HTML output were not displayed correctly in Safari. Specifying charset to utf-8 in HTML meta tag will fix this issue.

@ghost
Copy link

ghost commented Jan 3, 2020 •
edited by ghost
Loading

2 Messages
📖 View more details on Bitrise
📖 Tests: Executed 17 tests, with 0 failures (0 unexpected) in 0.315 (0.347) seconds

Current coverage for Diagnostics.framework is 76.64%

Files changed - -
DiagnosticsReporter.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

@AvdLee AvdLee self-assigned this Jan 6, 2020
AvdLee
AvdLee suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry as well?

@intitni intitni requested a review from AvdLee January 6, 2020 09:26
@AvdLee AvdLee merged commit ada293a into WeTransfer:master Jan 6, 2020
@wetransferplatform wetransferplatform mentioned this pull request May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvdLee AvdLee AvdLee approved these changes

Assignees

@AvdLee AvdLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intitni @AvdLee