Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Manifest #171

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

raphkoebraam
Copy link
Member

@raphkoebraam raphkoebraam commented Apr 16, 2024

This PR adds a privacy manifest file and makes a few improvements along the way.

This is a breaking change around UserDefaultsReporter, making sure that we are using it matching the privacy requirements. Because of these changes, UserDefaultsReporter is not part of the DefaultReporter.allReporters, requiring for users of the library to instantiate a UserDefaultsReporter themselves if they would like to use this reporter.

The main change is on how we're using UserDefaultsReporter internally to use UserDefaults. We decided to keep UserDefaultsReporter to make it less of a breaking change to the developers using Diagnostics, instead of removing it completely.

Before the changes, we were using the dictionaryRepresentation() in the UserDefaults instance, which would return everything contained in there. With the changes, we are now acting as wrapper, where the new API requires a UserDefaults instance and an array of keys that should be read from the given instance, so we iterate over the keys and fetch each of them individually. This allows us to use C56D.1 for the UserDefaults reason.

For more information around the privacy manifest file, please refer to Privacy manifest files.

Fixes TMOB-5314, #157 and #168.

@raphkoebraam raphkoebraam self-assigned this Apr 16, 2024
@raphkoebraam raphkoebraam requested a review from a team as a code owner April 16, 2024 14:34
@raphkoebraam raphkoebraam marked this pull request as draft April 16, 2024 14:37
@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Apr 16, 2024

Messages
📖 DiagnosticsTests: Executed 35 tests (0 failed, 0 retried, 0 skipped) in 11.574 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.014s)
📖 Slowest test: DiagnosticsReporterTests/testWithoutProvidingSmartInsightsProvider() (2.006s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningExtraInsights() (2.005s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 62.96% ⚠️

Generated by 🚫 Danger Swift against 82f8539

Sources/PrivacyInfo.xcprivacy Show resolved Hide resolved
Sources/PrivacyInfo.xcprivacy Show resolved Hide resolved
Sources/PrivacyInfo.xcprivacy Show resolved Hide resolved
@raphkoebraam raphkoebraam marked this pull request as ready for review April 16, 2024 14:40
@raphkoebraam raphkoebraam force-pushed the chore/raph/tmob-5314/privacy-manifest-update branch from fb95eaf to 82f8539 Compare April 17, 2024 11:23
@raphkoebraam raphkoebraam merged commit 2b6a279 into master Apr 17, 2024
2 checks passed
@raphkoebraam raphkoebraam deleted the chore/raph/tmob-5314/privacy-manifest-update branch April 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants