-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Privacy Manifest #171
Merged
raphkoebraam
merged 5 commits into
master
from
chore/raph/tmob-5314/privacy-manifest-update
Apr 17, 2024
Merged
Add Privacy Manifest #171
raphkoebraam
merged 5 commits into
master
from
chore/raph/tmob-5314/privacy-manifest-update
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed keys in the given user defaults instance This is in preparation for adding the privacy manifest
…` to make it easier to identify failure
raphkoebraam
requested review from
BasThomas,
AvdLee,
kairadiagne,
armanarutiunov and
swaan-miller
April 16, 2024 14:34
Closed
Code Coverage Report
Generated by 🚫 Danger Swift against 82f8539 |
raphkoebraam
commented
Apr 16, 2024
armanarutiunov
approved these changes
Apr 16, 2024
BasThomas
approved these changes
Apr 17, 2024
…ultsReporterTests`
raphkoebraam
force-pushed
the
chore/raph/tmob-5314/privacy-manifest-update
branch
from
April 17, 2024 11:23
fb95eaf
to
82f8539
Compare
This was referenced Apr 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a privacy manifest file and makes a few improvements along the way.
This is a breaking change around
UserDefaultsReporter
, making sure that we are using it matching the privacy requirements. Because of these changes,UserDefaultsReporter
is not part of theDefaultReporter.allReporters
, requiring for users of the library to instantiate aUserDefaultsReporter
themselves if they would like to use this reporter.The main change is on how we're using
UserDefaultsReporter
internally to useUserDefaults
. We decided to keepUserDefaultsReporter
to make it less of a breaking change to the developers usingDiagnostics
, instead of removing it completely.Before the changes, we were using the
dictionaryRepresentation()
in theUserDefaults
instance, which would return everything contained in there. With the changes, we are now acting as wrapper, where the new API requires aUserDefaults
instance and an array of keys that should be read from the given instance, so we iterate over the keys and fetch each of them individually. This allows us to useC56D.1
for theUserDefaults
reason.For more information around the privacy manifest file, please refer to Privacy manifest files.
Fixes TMOB-5314, #157 and #168.