Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMOB 5114] Log failures happening during log reading #165

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Mar 1, 2024

There have been instances where logs wouldn't be readable, failing with:

Parsing the log failed

Since we did not log any related failures, it's hard to conclude what went wrong. This PR enables logging thrown errors so we can better debug this in the future.

Note: often a regeneration/retry solved the issue for users.

@AvdLee AvdLee self-assigned this Mar 1, 2024
@AvdLee AvdLee requested a review from a team as a code owner March 1, 2024 13:07
@wetransferplatform
Copy link
Collaborator

Warnings
⚠️

Consider to place some MARK: lines for Sources/Logging/Loggable.swift, which is over 300 lines big.

Messages
📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.296 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.036s)
📖 Slowest test: DiagnosticsReporterTests/testWithoutProvidingSmartInsightsProvider() (2.014s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningNoExtraInsights() (2.010s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 64.18% ⚠️

Generated by 🚫 Danger Swift against 45a56ed

Copy link

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't think the linter changes are supposed to be in this PR as well?

@AvdLee AvdLee merged commit 4a362cc into master Mar 4, 2024
2 checks passed
@AvdLee AvdLee deleted the feature/tmob-5114-read-log-failure branch March 4, 2024 08:25
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.6.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants