Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SwiftLint warnings inside example project #164

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix SwiftLint warnings inside example project #164

merged 1 commit into from
Mar 4, 2024

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Mar 1, 2024

A little cleanup!

@AvdLee AvdLee requested a review from a team as a code owner March 1, 2024 12:57
@AvdLee AvdLee self-assigned this Mar 1, 2024
@wetransferplatform
Copy link
Collaborator

Warnings
⚠️

Consider to place some MARK: lines for Sources/Logging/Loggable.swift, which is over 300 lines big.
Messages
📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.896 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.018s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningNoExtraInsights() (2.014s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningExtraInsights() (2.011s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 63.66% ⚠️

Generated by 🚫 Danger Swift against 43dbdad

@AvdLee AvdLee merged commit 0449744 into master Mar 4, 2024
2 checks passed
@AvdLee AvdLee deleted the feature/fix-swiftlint-warnings branch March 4, 2024 08:23
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.6.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanarutiunov armanarutiunov armanarutiunov approved these changes

@kairadiagne kairadiagne kairadiagne approved these changes

@raphkoebraam raphkoebraam raphkoebraam approved these changes

@BasThomas BasThomas BasThomas approved these changes

@swaan-miller swaan-miller Awaiting requested review from swaan-miller swaan-miller was automatically assigned from WeTransfer/ios-collect

Assignees

@AvdLee AvdLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AvdLee @wetransferplatform @BasThomas @raphkoebraam @kairadiagne @armanarutiunov