-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: unblock building for VisionOS Simulator #155
Conversation
Code Coverage Report
Generated by 🚫 Danger Swift against cced7c2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgorrindo, before merging this in, could you please go over the SwiftLint found issues
section in the comment above and fix the warnings? 🙏
done, thanks! |
@pgorrindo thanks for your contribution 💪 |
hi @peagasilva et al - looks like auto-merge is blocked because my commits weren't signed 🤦 -- apologies, I've been fiddling with 1Password's CLI lately and that has messed up my normal GH auth. Any chance one of you with admin privs could manually merge this in? thanks in advance! |
@pgorrindo we can't manually merge this in, unfortunately. However, there's a way to recommit with signed commits:
You can read more about setting up signed commits here. |
thanks all, and sorry for the hassle 😇 -- @AvdLee my commits are signed now -- and it looks like all auto-merge criteria are fulfilled. maybe Bitrise needs to be re-triggered? |
Congratulations! 🎉 This was released as part of Release 4.6.0 🚀 Generated by GitBuddy |
When building for the VisionOS simulator, Xcode throws errors on availability of
CoreTelephony
. This PR conditionally importsCoreTelephony
.