Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unblock building for VisionOS Simulator #155

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Fix: unblock building for VisionOS Simulator #155

merged 4 commits into from
Sep 18, 2023

Conversation

pgorrindo
Copy link
Contributor

When building for the VisionOS simulator, Xcode throws errors on availability of CoreTelephony. This PR conditionally imports CoreTelephony.

Screenshot 2023-09-01 at 16 26 34

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Sep 2, 2023

Messages
📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.219 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.017s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningExtraInsights() (2.010s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningNoExtraInsights() (2.005s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 63.61% ⚠️

Generated by 🚫 Danger Swift against cced7c2

Copy link
Member

@raphkoebraam raphkoebraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgorrindo, before merging this in, could you please go over the SwiftLint found issues section in the comment above and fix the warnings? 🙏

@pgorrindo
Copy link
Contributor Author

@pgorrindo, before merging this in, could you please go over the SwiftLint found issues section in the comment above and fix the warnings? 🙏

done, thanks!

@AvdLee
Copy link
Contributor

AvdLee commented Sep 5, 2023

@pgorrindo thanks for your contribution 💪

@pgorrindo
Copy link
Contributor Author

hi @peagasilva et al - looks like auto-merge is blocked because my commits weren't signed 🤦 -- apologies, I've been fiddling with 1Password's CLI lately and that has messed up my normal GH auth. Any chance one of you with admin privs could manually merge this in? thanks in advance!

@AvdLee
Copy link
Contributor

AvdLee commented Sep 11, 2023

@pgorrindo we can't manually merge this in, unfortunately. However, there's a way to recommit with signed commits:

git rebase --exec 'git commit --amend --no-edit -n -S' master
git push --force

You can read more about setting up signed commits here.

@pgorrindo
Copy link
Contributor Author

thanks all, and sorry for the hassle 😇 -- @AvdLee my commits are signed now -- and it looks like all auto-merge criteria are fulfilled. maybe Bitrise needs to be re-triggered?

@AvdLee AvdLee merged commit 7f65bd4 into WeTransfer:master Sep 18, 2023
1 check failed
@pgorrindo pgorrindo deleted the coretelephony-visionos branch September 19, 2023 00:02
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.6.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants