-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum iOS support to iOS 11 #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm not sure how others feel about taking care of support for iOS 11+, though... 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine adding support for iOS 11 for now. As soon as we run into issues later on, we can always drop support again. Looking at the changes, however, it seems low effort now 👌
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks again @antranapp :)
Oh, one more thing. We've been requiring signed commits for a while. Can you rebase and sign your commits by chance, @antranapp? Let me know if that is something you'd need assistance with. |
Signed-off-by: An Tran <tran.binhan@gmail.com>
@BasThomas I have signed my commit and force push again. |
Code Coverage Report
SwiftLint found issues
Generated by 🚫 Danger Swift against 09f542d |
@antranapp thanks for your contribution! |
Awesome, thanks again @antranapp and @AvdLee for merging! :) |
Congratulations! 🎉 This was released as part of Release 4.4.0 🚀 Generated by GitBuddy |
We would like to integrate this great package into our app but our app is still supporting iOS 11+.
It looks like that the main functionality of the package is available for iOS 11, only a default SmartInsight requires iOS 13+ due to Combine
I have added some availability checks for that SmartInsight and set the minimum iOS platform version to 11.