Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weapon info into debug window #1998

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

gantsevdenis
Copy link
Contributor

Also, maybe we need to localize the debug window content?..

@thiagorb
Copy link
Member

Nice PR!

About translating the debug window I’m not sure… it’s a tool for developers and the developers should speak English, and be able to refer to game related things in English. It might make it harder for volunteer translators to understand the context. I’m not against but I wouldn’t put effort on it. What do you think?

@gantsevdenis
Copy link
Contributor Author

I had exactly the same thought, and that's why I am not sure... While i think it would make sense to translate something like "Hit points" and "Weapon"; translating something like "Triggers" and its content would be completely useless.
And then having half of window in English, and the other half localized isn't pretty.

I don't have a final answer :)
Maybe leave it like it is currently, and if people ask for it, then we d translate

@KJeff01
Copy link
Member

KJeff01 commented Jul 14, 2021

The buttons are very compact. There is also one problem: Imagine trying to fit some monstrous 30 character German word into ~30 pixel for an average sized button.

@highlander1599
Copy link
Contributor

The buttons are very compact. There is also one problem: Imagine trying to fit some monstrous 30 character German word into ~30 pixel for an average sized button.

30 characters would be short. ;)

@thiagorb thiagorb merged commit 0a626c3 into Warzone2100:master Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants