Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(api): Fix api reponse on build failure #18

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

misnard
Copy link
Contributor

@misnard misnard commented Jan 25, 2024

On "failure" because of the new error status, the action stay stuck at # Now at stage: x

Caused by an update of the api response -> https://developers.cloudflare.com/pages/platform/changelog/#support-for-d1s-new-storage-subsystem-and-build-error-message-improvements

@misnard
Copy link
Contributor Author

misnard commented Mar 8, 2024

Hey any update ? :)

@WalshyDev
Copy link
Owner

Oh crap I completely missed this, apologies! Let me see

Copy link
Owner

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this forever ago haha, ty! Looks good after this change

.idea/workspace.xml Outdated Show resolved Hide resolved
@misnard
Copy link
Contributor Author

misnard commented Mar 14, 2024

It's updated :)

@misnard
Copy link
Contributor Author

misnard commented Mar 15, 2024

I don't have the right to merge @WalshyDev

@WalshyDev WalshyDev merged commit 3abae9f into WalshyDev:main Mar 16, 2024
1 check passed
mlafeldt pushed a commit to mlafeldt/cf-pages-await that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants