-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Make client to compute RoundId
#13514
Merged
lontivero
merged 3 commits into
WalletWasabi:master
from
lontivero:make-client-to-compoute-roundid
Oct 21, 2024
Merged
[BugFix] Make client to compute RoundId
#13514
lontivero
merged 3 commits into
WalletWasabi:master
from
lontivero:make-client-to-compoute-roundid
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lontivero
changed the title
Make client to compute
[BugFix] Make client to compute Oct 21, 2024
RoundId
RoundId
turbolay
previously approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK, LGTM
Please fix CanGetDifferentialStateTest
before merging
lontivero
force-pushed
the
make-client-to-compoute-roundid
branch
from
October 21, 2024 19:13
2e4d4aa
to
f616acf
Compare
Kukks
pushed a commit
to Kukks/WalletWasabi
that referenced
this pull request
Oct 22, 2024
* Client-side RoundId verification * Client-side OwnershipProofs verification * Fix UT
lontivero
added a commit
that referenced
this pull request
Oct 22, 2024
lontivero
added a commit
to lontivero/WalletWasabi
that referenced
this pull request
Oct 23, 2024
lontivero
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client was trusting on the coordinator round id instead of computing it by itself. This PR is for fixing that and also to verify that all inputs registered in a round were created for that round only, this is done by verifying their ownership proofs.