Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Make client to compute RoundId #13514

Merged

Conversation

lontivero
Copy link
Collaborator

Client was trusting on the coordinator round id instead of computing it by itself. This PR is for fixing that and also to verify that all inputs registered in a round were created for that round only, this is done by verifying their ownership proofs.

@lontivero lontivero requested a review from turbolay October 21, 2024 18:34
@lontivero lontivero changed the title Make client to compute RoundId [BugFix] Make client to compute RoundId Oct 21, 2024
@lontivero lontivero added bug priority Resiliency All what makes Wasabi inmortal FOSS labels Oct 21, 2024
turbolay
turbolay previously approved these changes Oct 21, 2024
Copy link
Collaborator

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK, LGTM
Please fix CanGetDifferentialStateTest before merging

@lontivero lontivero merged commit bff5760 into WalletWasabi:master Oct 21, 2024
3 checks passed
Kukks pushed a commit to Kukks/WalletWasabi that referenced this pull request Oct 22, 2024
* Client-side RoundId verification

* Client-side OwnershipProofs verification

* Fix UT
lontivero added a commit that referenced this pull request Oct 22, 2024
turbolay pushed a commit that referenced this pull request Oct 22, 2024
lontivero added a commit to lontivero/WalletWasabi that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug FOSS priority Resiliency All what makes Wasabi inmortal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants