Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Private.Uri issue #12822

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

kiminuo
Copy link
Contributor

@kiminuo kiminuo commented Apr 11, 2024

There is a denial of service vulnerability in System.Private.Uri in version 4.3.0 and CodeFactor reports it1. This PR bumps it to 4.3.2.

To be warned about vulnerabilities during dotnet restore (shorter feedback loop), I enabled in Directory.Build.props:

<!-- Audit both top-level and transitive dependencies for vulnerabilities in NuGet packages. -->
<!-- https://learn.microsoft.com/en-us/nuget/concepts/auditing-packages#setting-a-security-audit-mode -->
<NuGetAuditMode>all</NuGetAuditMode>
<NuGetAuditLevel>low</NuGetAuditLevel>

This makes sure that not only CodeFactor warns us about vulnerabilities but even .NET during a restore/build. The output is then as follows:

6>Z:\WalletWasabi\WalletWasabi.Fluent\WalletWasabi.Fluent.csproj : warning NU1903: Package 'System.Private.Uri' 4.3.0 has a known high severity vulnerability, https://github.com/advisories/GHSA-5f2m-466j-3848
6>Z:\WalletWasabi\WalletWasabi.Fluent\WalletWasabi.Fluent.csproj : warning NU1902: Package 'System.Private.Uri' 4.3.0 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-x5qj-9vmx-7g6g
6>Z:\WalletWasabi\WalletWasabi.Fluent\WalletWasabi.Fluent.csproj : warning NU1903: Package 'System.Private.Uri' 4.3.0 has a known high severity vulnerability, https://github.com/advisories/GHSA-xhfc-gr8f-ffwc

Similar vulnerability in other projects

Footnotes

  1. Whenever we would try to upgrade a dependency at this point.

@kiminuo kiminuo force-pushed the feature/2024-04-11-Upgrade-deps branch from a48c71f to 663623f Compare April 11, 2024 12:55
@kiminuo kiminuo changed the title Upgrade deps if it fixes CF or not System.Private.Uri issue Apr 11, 2024
@kiminuo kiminuo force-pushed the feature/2024-04-11-Upgrade-deps branch from b8e036b to 7f3ac0a Compare April 15, 2024 06:36
@kiminuo kiminuo marked this pull request as ready for review April 15, 2024 06:42
@kiminuo kiminuo requested a review from molnard April 15, 2024 06:42
Copy link
Contributor

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Good catch.

@molnard molnard merged commit 85f6bfe into WalletWasabi:master Apr 15, 2024
7 of 8 checks passed
@kiminuo kiminuo deleted the feature/2024-04-11-Upgrade-deps branch April 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants