Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Use RoutingStrategies.Bubble for pointer event for closing dialog #12468

Merged
merged 1 commit into from
Feb 14, 2024
Merged

[VDG] Use RoutingStrategies.Bubble for pointer event for closing dialog #12468

merged 1 commit into from
Feb 14, 2024

Conversation

wieslawsoltes
Copy link
Contributor

Fixes #12430

@wieslawsoltes wieslawsoltes mentioned this pull request Feb 14, 2024
Closed
@RolandUI RolandUI requested a review from MarnixCroes February 14, 2024 09:31
MarnixCroes
MarnixCroes approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tack 059ad99

@MaxHillebrand MaxHillebrand added this to the v2.0.6 milestone Feb 14, 2024
RolandUI
RolandUI approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@RolandUI RolandUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played with it a bit. tACK

@RolandUI RolandUI merged commit 8ed15fe into WalletWasabi:master Feb 14, 2024
7 checks passed
@molnard
Copy link
Contributor

molnard commented Feb 16, 2024

Sorry if irrelevant but I don't see PR that is merging this to the release branch. Can you verify if it is merged, if not then create a PR for that.

@RolandUI
Copy link
Contributor

Sorry if irrelevant but I don't see PR that is merging this to the release branch. Can you verify if it is merged, if not then create a PR for that.

It seems like this change is already in the release branch. (I don't see any PR either though)

@yahiheb
Copy link
Collaborator

yahiheb commented Feb 19, 2024

This is the PR #12471

@wieslawsoltes wieslawsoltes deleted the vdg/fix-12430-fix-dialog-closing branch March 5, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarnixCroes MarnixCroes MarnixCroes approved these changes

@RolandUI RolandUI RolandUI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.6
Development

Successfully merging this pull request may close these issues.

[UI] Buy Anything Button dialog closes when selecting category
6 participants
@wieslawsoltes @molnard @RolandUI @yahiheb @MarnixCroes @MaxHillebrand