fixup! feat(core): add viaProxy Utility to rewrite requests to proxy (m…

…otion-canvas#338)

packages/vite-plugin/src/main.ts

@@ -77,10 +77,10 @@ export interface MotionCanvasPluginConfig {
    *
    * @remarks
    * This passes configuration to Motion Canvas' proxy.
-   * Not setting this value will allow all `image/*` and `video/*` resources from any hostname.
-   * You can also disable the proxy entirely by passing `false`. This will however mean that you
-   * cannot render any animation that relies on remote sources.
-   */
+   * Note that the proxy is disabled by default.
+   * You can either pass `true` and a config object
+   * to enable it.
+   **/
   proxy?: boolean | MotionCanvasCorsProxyOptions;
 }
 
@@ -332,12 +332,11 @@ export default ({
         next();
       });
 
-      // This is intentionally !== false as undefined should be allowed
-      if (proxy !== false) {
-        motionCanvasCorsProxy(
-          server.middlewares,
-          proxy === true ? undefined : proxy,
-        );
+      // if proxy is unset (undefined), or set to false,
+      // it will not register its middleware — as a result, no
+      // proxy is started.
+      if (proxy !== false && proxy !== undefined) {
+        motionCanvasCorsProxy(server.middlewares, proxy === true ? {} : proxy);
       }
 
       server.ws.on('motion-canvas:meta', async ({source, data}, client) => {

packages/vite-plugin/src/proxy-middleware.ts

@@ -53,7 +53,7 @@ export function setupEnvVarsForProxy(
   const isEnabledKey = prefix + 'ENABLED';
   const allowList = prefix + 'ALLOW_LIST';
 
-  if (config === true || config === undefined) {
+  if (config === true) {
     config = {}; // Use Default values
   }
 
@@ -69,7 +69,7 @@ export function setupEnvVarsForProxy(
 
 export function motionCanvasCorsProxy(
   middleware: Connect.Server,
-  config: MotionCanvasCorsProxyOptions | undefined = {},
+  config: MotionCanvasCorsProxyOptions,
 ) {
   // Set the default config if no config was provided
   config.allowedMimeTypes ??= ['image/*', 'video/*'];