Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved Bug 1427: Design System > Element > App detail > Default > Missing Controls and missing formatting. #1428

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Resolved Bug 1427: Design System > Element > App detail > Default > Missing Controls and missing formatting. #1428

merged 4 commits into from
Feb 4, 2025

Conversation

rameshwarkamandar
Copy link
Collaborator

Description

Resolved Issue on Missing Controls and missing formatting.

  • App Detail

Make the changes to /rds-app-detail.stories.tsx, /rds-app-detail.tsx file.
Added missing controls.
Add href dynamic.
Add position for icon: - left, center, right
Update interface.

Screenshots:

image
image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rameshwarkamandar rameshwarkamandar added the Bug Something isn't working label Feb 3, 2025
@rameshwarkamandar rameshwarkamandar self-assigned this Feb 3, 2025
@rameshwarkamandar rameshwarkamandar linked an issue Feb 3, 2025 that may be closed by this pull request
Design System > Element > App detail > Default > Missing Controls and missing formatting #1427
Open
nknikhilkasar
nknikhilkasar approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@nknikhilkasar nknikhilkasar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nknikhilkasar
Merge branch 'development' into users/rameshwar/bug/1427-elements-app…
bb92ef1 
…-detail-Missing-controls-and-missing-formatting
@rameshwarkamandar rameshwarkamandar merged commit cff994b into development Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknikhilkasar nknikhilkasar nknikhilkasar approved these changes

@WAi-Aditya WAi-Aditya Awaiting requested review from WAi-Aditya

Assignees

@rameshwarkamandar rameshwarkamandar

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design System > Element > App detail > Default > Missing Controls and missing formatting
2 participants
@rameshwarkamandar @nknikhilkasar