Implement Stop the subscription to message notifications #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidathWeerasinghe
force-pushed
the
feature_ussd_sms
branch
from
52cef77 to
9ae8337
Compare
Nuwan-Walisundara
suggested changes
Mar 16, 2017
| transaction.commit(); | ||
|
|
||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
rollback if exception and print the ,or rethrow
SidathWeerasinghe
force-pushed
the
feature_ussd_sms
branch
from
9ae8337 to
6aba8a8
Compare
Nuwan-Walisundara
suggested changes
Mar 16, 2017
|
|
||
| } catch (Exception e) { | ||
| transaction.rollback(); | ||
| throw new Exception("Error occurred when saving subscribe SMS request."); |
There was a problem hiding this comment.
send the same exception, dont create new one, log the error to logger
SidathWeerasinghe
force-pushed
the
feature_ussd_sms
branch
from
6aba8a8 to
bcf3bf3
Compare
SidathWeerasinghe
force-pushed
the
feature_ussd_sms
branch
from
bcf3bf3 to
b4f10ac
Compare
Nuwan-Walisundara
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.