This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Update cra fork #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add question issue template * Fix bug report template formatting * Fix bug report template formatting * Add labels to pull request template
* Update deploy instructions in contributing guide * Update docs publishing instructions
* Added dependencies to bootstrap article when using custom SCSS. * Make changes to package designation and added npm install directions.
preprocessor will output sourceMap by default then check if sourceMaps are needed on resolve-url-loader Fixes facebook#4653
* Adjusted deployment documentation for ZEIT Now * Fixed missing word * Update docusaurus/docs/deployment.md Co-Authored-By: Joe Haddad <timer150@gmail.com>
Exclude URLs that contains a "?" character.
* Remove unused dependencies in babel-preset-react-app * Re-add @babel/plugin-transform-react-display-name * Remove some dependencies again
Declare namespaces are supported by babel now, and babel will throw with a nice error message for non-declare namespaces, so this rule is unnecessary. Closes facebook#7651.
This is just a comment fix. Actual optional chaining operator syntax is `?.`, not `.?`.
* security: update terser webpack plugin
Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules.
* Bump dependencies in react-dev-utils * Bump dependencies in react-app-polyfill * Bump dependencies in create-react-app * Bump dependencies in react-error-overlay * Bump dependencies in react-scripts * Bump react
* Add package-runner note to readme * Add link to `yarn create`
- Remove templates version minimum stopgap. - Replace indexOf with more idiomatic alternatives. - Inline errorLogFilePatterns. - Alphabetize validFiles. - Simplify log file removal code. - Move unconditional console.log() call outside of isSafe. - Differentiate conflicting directories from files. - Document yarn version special case. - Inline printValidationResults. - Standardize checkAppName output on failure. - Add link for checkThatNpmCanReadCwd. Functionally the code should be exactly the same.
nvioli
approved these changes
Dec 18, 2019
Co-authored-by: Eric Clemmons <eric@smarterspam.com> Co-authored-by: Alex Guerra <alex@heyimalex.com>
…rewluca/create-react-app into update-cra-fork * 'public-url-in-development' of https://github.com/iamandrewluca/create-react-app: feat(react-scripts): allow PUBLIC_URL in develoment mode Bump babel-plugin-tester and fix breaking changes (facebook#8171) fix: proactively append to .gitignore during init (facebook#8028) Minor refactors in create-react-app (facebook#8178) Update PWA docs links to point to template package (facebook#8147) Add package-runner note to readme (facebook#8132) Bump internal dependencies (facebook#8176) Add link to Netlify in README Bump chalk (facebook#8164) Bump pkgUp (facebook#8163) Add current version and bin location to --info output (facebook#8168) [Security] Update terser webpack plugin (facebook#8102)
nvioli
reviewed
Jan 2, 2020
| // It is important to tell WebpackDevServer to use the same "publicPath" path as | ||
| // we specified in the Webpack config. When homepage is '.', default to serving | ||
| // from the root. | ||
| publicPath: shouldUseRelativeAssetPaths ? '/' : paths.servedPath, | ||
| publicPath: paths.publicUrlOrPath, | ||
| // WebpackDevServer is noisy by default so we emit custom message instead | ||
| // by listening to the compiler events with `compiler.hooks[...].tap` calls above. | ||
| quiet: false, |
There was a problem hiding this comment.
The only difference I see between your branch and upstream is this setting. When I forked in July, upstream had it as false, but after rebasing, upstream now has it as true. I don't feel strongly about it; if you find the additional logging useful it's find as is, but if you're just defaulting to what I had on my branch before, I'd be in favor of copying the decision they made (changing to true) to keep things in sync.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to latest react-scripts from https://github.com/iamandrewluca/create-react-app/tree/public-url-in-development