-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bound validity periods to 90 days. #383
Conversation
We don't, today, enforce a maximum validity outside of the 825 days for all public TLS certs. It'll require a relatively small change to add a lower max validity, but it's not a major issue. My only concern would be a nearish-term change to that max validity again. Meaning that I'd like to see some very rough consensus on max validity before we start working in that update. |
We are now ordering a SXG certificate to Digicert. Shortening its lifetime affects our budget and operation plan for our SXG trial. Please also consider the issuing process with CA because ACME is not used for it. |
It'd be probably helpful to clarify what should / would happen to the sites that are already experimenting (or ordering) when this change takes effect, and on any other nearish-term changes. |
@shigeki Just a note that ordering for shorter validity will also automatically prorate/decrease the price of the certificate relative to the validity selected. If you need any help with your account or testing, please don't hesitate to reach out. |
@clintwilson Thank for offering your help. We can purchase only one or two years SXG certs via Cyberturst in Japan. ACME needs challenge and response so that we can do it to fallbackURL if it is online. Currently fallbackURL is implemented as reqeustURL. That has a risk to renew the existing cert in online . I think it is too early to limit the lifetime of SXG cert in 90 days for we do not know if it can really operative. 6.2. Off-path attackers in Security considerations only describes about an attacker who already possesses a valid certificate. We should add the consideration of how much we need to care about misissuance of CA before discussing SXG cert lifetime. Do we really need to care about a serious CA incident such as DigiNotar in 2011? |
This is not necessarily the limit we'll want in the long run, but it helps ensure that any future changes can go into effect reasonably quickly.
The first cutoff is shortly after Chrome 74 is expected to reach stable. The second cutoff is 3 months later, approximately when Chrome 76 is expected to reach stable.
d36122f
to
c146253
Compare
@shigeki Thanks for the feedback and for continuing the conversation via @sisidovski. It looks like you've found a way to get a <1-year certificate that matches the timeline I added here since your comment. I wrote up some considerations at #378 (comment) that I think mean we should go for a 90-day max-lifetime for this year, and the other 2 people who voted, agreed. Given that, I'm going to merge this change. |
This implements WICG/webpackage#383. After this patch, SignedExchangeHandler rejects certificates that have validity period longer than 90 days, if - the validity period starts after 2019-05-01, or - the verification date is after 2019-08-01. Bug: 953165 Change-Id: I607952af6a315ca3c4f5743bc8b0dd4ae71a5057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569371 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#651623} Former-commit-id: 4a0bd3fa56c8f6dcfd2696ecbce2bbf3ceaf922c
Use `-days 90` when creating a self-signed certificate, as certificate lifetime is limited to maximum 90 days. (#383)
This is not necessarily the limit we'll want in the long run, but it
helps ensure that any future changes can go into effect reasonably
quickly.
I won't submit this until I have some indication that the folks who have already started experimenting with signed exchanges can handle 90-day certificates.
@clintwilson, I want to make sure this doesn't cause any problems for you, since I believe Digicert has been issuing certificates with validity periods longer than 90 days. I don't intend to declare that any of your existing certificates are out of bounds.
@AGWA, this isn't intended to stop discussion on #378, just to put some limit in place while we figure out what the right limit is.
Preview: https://jyasskin.github.io/webpackage/90-day-lifetime/draft-yasskin-http-origin-signed-responses.html#cross-origin-cert-req
Diff: https://tools.ietf.org/rfcdiff?url1=https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.txt&url2=https://jyasskin.github.io/webpackage/90-day-lifetime/draft-yasskin-http-origin-signed-responses.txt