Add optional perBuyerTimeouts to auction config. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows sellers to optionally restrict the runtime of bidder scripts, with a default of 100 ms and a hard-cap of 500 ms. Fixes WICG#90
This will apply to any buyer bidding scripts that don't otherwise have a `perBuyerTimeouts` specified.
|
@caraitto - can you join the WICG to appease the IPR bots? |
I sent a request -- I'm just waiting for approval. |
Thanks, looks like I'm good to go now. |
|
Thanks @caraitto this looks great. I suspect that this won't be the only control we'll need for resource limits; even with a per-bidder-script limit, an unbounded number of bidding IGs could still cause pain. But that will require more subtlety. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows sellers to optionally restrict the runtime of bidder scripts, with a default of 100 ms and a hard-cap of 500 ms.
Fixes #90