Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change config to be an attribute getter." #108

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

otherdaniel
Copy link
Collaborator

This reverts commit f3f52ce.

See discussion at #107.

This reverts commit f3f52ce.

See discussion at WICG#107.
@mozfreddyb
Copy link
Collaborator

mozfreddyb commented Jul 9, 2021

getConfig?

@otherdaniel
Copy link
Collaborator Author

getConfig?

This is currently a clean revert, courtesy of git revert.

I can also change the name.. .getConfig, or .getConfiguration?

@otherdaniel otherdaniel merged commit aa33d25 into WICG:main Jul 9, 2021
github-actions bot added a commit that referenced this pull request Jul 9, 2021
SHA: aa33d25
Reason: push, by @otherdaniel

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Jul 12, 2021
Refs:
- github.com/WICG/sanitizer-api/issues/92
- github.com/WICG/sanitizer-api/issues/107
- WICG/sanitizer-api#108

Bug: 1213893
Change-Id: Ibbc89e2678107f835517af9743e5a1eeca3911d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3015576
Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900407}
@otherdaniel otherdaniel deleted the revert-accessor branch July 13, 2021 14:41
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
Refs:
- github.com/WICG/sanitizer-api/issues/92
- github.com/WICG/sanitizer-api/issues/107
- WICG/sanitizer-api#108

Bug: 1213893
Change-Id: Ibbc89e2678107f835517af9743e5a1eeca3911d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3015576
Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900407}
NOKEYCHECK=True
GitOrigin-RevId: 66474c9aa1cf094fcbcf75ebea5d11255b17bd81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants