Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all existing aria- elements are known and allowed #177

Closed
mozfreddyb opened this issue Oct 6, 2022 · 1 comment
Closed

Ensure that all existing aria- elements are known and allowed #177

mozfreddyb opened this issue Oct 6, 2022 · 1 comment
Assignees

Comments

@mozfreddyb
Copy link
Collaborator

I'll make a list of all existing aria- attributes. We do not want to remove accessibility features from HTML.

Sidenote: We do not have the same issue with data- attributes. Those attributes are removed by default and can be kept with a configuration as they will not be listed in known attributes. For aria, we want to keep them by default.

@mozfreddyb mozfreddyb self-assigned this Oct 6, 2022
@mozfreddyb
Copy link
Collaborator Author

The Mozilla a11y friends tell me that the section 6.7 Definitions of States and Properties (all aria- attributes)* in the ARIA spec does indeed contain all aria attributes 😅. That made it relatively easy and I got them out of the spec in a hacky way using a code snippet like Array.from($("#index_state_prop").querySelectorAll("dt")).map(el => el.textContent) in DevTools.

I'm going to submit a pull request to add them to our known attribute list

aria-activedescendant aria-atomic aria-autocomplete aria-braillelabel aria-brailleroledescription aria-busy aria-checked aria-colcount aria-colindex aria-colindextext aria-colspan aria-controls aria-current aria-describedby aria-description aria-details aria-disabled aria-dropeffect aria-errormessage aria-expanded aria-flowto aria-grabbed aria-haspopup aria-hidden aria-invalid aria-keyshortcuts aria-label aria-labelledby aria-level aria-live aria-modal aria-multiline aria-multiselectable aria-orientation aria-owns aria-placeholder aria-posinset aria-pressed aria-readonly aria-relevant aria-required aria-roledescription aria-rowcount aria-rowindex aria-rowindextext aria-rowspan aria-selected aria-setsize aria-sort aria-valuemax aria-valuemin aria-valuenow aria-valuetext

mozfreddyb added a commit to mozfreddyb/sanitizer-api that referenced this issue Oct 19, 2022
github-actions bot added a commit that referenced this issue Oct 19, 2022
…177) (#180)

SHA: 3001500
Reason: push, by mozfreddyb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant