Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Privacy section to clarify network change #29

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Update Privacy section to clarify network change #29

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8606e85
Clean up main branch
mingyc Aug 29, 2022
ebe91cc
Update Privacy section to clarify why beacon needs to be stopped when
mingyc Sep 5, 2022
5d0e7c9
Addressed comments and update other items in privacy section
mingyc Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Authors: [Darren Willis](https://github.com/darrenw), [Fergal Daly](https://github.com/fergald), [Ming-Ying Chung](https://github.com/mingyc) - Google

[![Super-Linter](https://github.com/WICG/unload-beacon/workflows/linter.yml/badge.svg)](https://github.com/WICG/unload-beacon/actions/workflows/super-linter.yml)
[![Super-Linter](https://github.com/WICG/unload-beacon/workflows/Lint%20Code%20Base/badge.svg)](https://github.com/WICG/unload-beacon/actions/workflows/super-linter.yml)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it shouldn't be in this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is already commited to main branch. Not sure how to remove it from this PR but should be no-op on merging.

[![Spec Prod](https://github.com/WICG/unload-beacon/actions/workflows/auto-publish.yml/badge.svg)](https://github.com/WICG/unload-beacon/actions/workflows/auto-publish.yml)


Expand Down Expand Up @@ -305,8 +305,8 @@ special support may be needed to allow extension authors to block the sending (o
Specifically, beacons will have the following privacy requirements:

* Beacons must be sent over HTTPS.
* Beacons are only sent over the same network that was active when the beacon was registered
(e.g. if the user goes offline and moves to a new network, discard pending beacons).
* Beacons must not leak information that a page should not know when it is in bfcache,
e.g. if network changes after a page goes into bfcache, the beacon should not be sent; if the page then goes out of bfcache, the beacon can be sent.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could suggest

"if the page is then restored from bfcache"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* Delete pending beacons for a site if a user clears site data.
* Beacons registered in an incognito session do not persist to disk.
* Follow third-party cookie rules for beacons.
Expand Down
Loading