Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the value argument be consistent #167

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Let the value argument be consistent #167

merged 1 commit into from
Aug 4, 2024

Conversation

maraisr
Copy link
Collaborator

@maraisr maraisr commented Aug 2, 2024 •
edited by pr-preview bot
Loading

Am currently implementing forEach in WebKit, and noticed we had some inconsistencies with what we call the value we pass these callbacks. Lets tidy this up in the spec.

cc @keithamus

Preview | Diff

keithamus
keithamus approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a sensible change given that Predicate takes a value, and also element may be confusing for developers in the context of the DOM.

@domfarolino
Copy link
Collaborator

Thanks so much! This makes sense. Happy to approve and bulldoze the IPR bot this time, but if you plan on making more (larger, is the key) contributions, then I think we should have you sign up for WICG so that the bot is by default happy. Feel free to sign up with the link in the checks section above.

@w3cbot
Copy link

w3cbot commented Aug 4, 2024

domfarolino marked as non substantive for IPR from ash-nazg.

@domfarolino domfarolino merged commit 6aecc70 into WICG:master Aug 4, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Aug 4, 2024
@maraisr @github-actions
Let the value argument be consistent in Mapper and Visitor (#167)
d4bef3d 
SHA: 6aecc70
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@maraisr maraisr deleted the mr/tovalue branch August 5, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@domfarolino domfarolino domfarolino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maraisr @domfarolino @w3cbot @keithamus