Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec async iterable from() conversion #191

Closed
domfarolino opened this issue Jan 25, 2025 · 0 comments · Fixed by #193
Closed

Spec async iterable from() conversion #191

domfarolino opened this issue Jan 25, 2025 · 0 comments · Fixed by #193
Assignees

Comments

@domfarolino
Copy link
Collaborator

All of the async iterable conversion was specified in #160, but it got a little complicated, so I decided to rip the async iterable conversion prose out of it, land that PR with everything but async iterable conversion support, and file this issue as a tracker issue to follow-up on that task. Mostly it just involves adding back the prose that was removed in 57b2d19, and ensure we resolve the following comments from that PR:

@domfarolino domfarolino self-assigned this Jan 25, 2025
domfarolino added a commit that referenced this issue Jan 25, 2025
This PR implements the `from()` static conversion operator, with the exception of the async iterable conversion semantics which is tracked as a follow-up issue in #191. This PR also uses the "from" conversion algorithm in `takeUntil()` on the notifier argument, for starters.

---------

Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant