Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update href_matches examples #286

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update href_matches examples #286

merged 1 commit into from
Nov 14, 2023

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Nov 14, 2023

Now that URL patterns are better, as of whatwg/urlpattern@ed205a4, we no longer need the ?* or ?# syntax.

Fixes #259.

Now that URL patterns are better, as of whatwg/urlpattern@ed205a4, we no longer need the ?* or ?*#* syntax.

Fixes #259.
@domenic domenic merged commit 18ea600 into main Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All our examples using /*\\?* URL pattern syntax break for fragment links
2 participants