Fix drag and drop example #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchris
reviewed
Jan 24, 2022
index.bs
Outdated
| } | ||
| const fileHandlesPromises = [...e.dataTransfer.items] | ||
| .filter((item) => item.kind === 'file') | ||
| .map((item) => item.getAsFileSystemHandle()); |
There was a problem hiding this comment.
you don't need () around item when there is just one argument. .map(item => item.getAsFileSystemHandle()); works fine
There was a problem hiding this comment.
It's a style guide thing. Google highly recommends adding braces.
There was a problem hiding this comment.
I see. I usually leave them out as they just add more noise and make the code less readable in my opinion :-)
There was a problem hiding this comment.
This is the spec, the Google Style Guide doesn't apply here. Feel free to remove, I don't have hard feelings. It's a prettier rule that I have in muscle memory :-)
tomayac
commented
Jan 24, 2022
mkruisselbrink
approved these changes
Feb 11, 2022
github-actions bot
added a commit
that referenced
this pull request
Feb 11, 2022
* Fix drag and drop example Fixes #356 * Update index.bs SHA: 2ccefeb Reason: push, by @mkruisselbrink Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fivedots
pushed a commit
that referenced
this pull request
Feb 28, 2022
* Fix drag and drop example Fixes #356 * Update index.bs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356
Preview | Diff