Update permissions policy to match implementation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
reviewed
Nov 1, 2023
domfarolino
reviewed
Nov 1, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 7, 2023
SHA: f806eda Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current permisisons policy spec patches correctly have the load blocking algorithm where we won’t load a fenced frame if any of the effective enabled permissions are not set. The patches do not, however, handle setting the permissions policies correctly. The spec allows the create a permissions policy algorithm to simply inherit from its embedder, which allows for information to leak across a fenced boundary.
This PR patches that so that the permissions that are set when a fenced frame loads are only the permissions in the "effective enabled permissions". This will ensure that all the permissions required to load are set (since that is checked at navigation time), but will not allow extra permissions to be enabled (including permissions set in the
allowattribute of the fenced frame).See document for more information.
Preview | Diff