This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
Fix coep violation report type for CORP #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @arturjanc |
yutakahirano
force-pushed
the
yhirano/reporting-feedback
branch
from
4fc97b6 to
1524220
Compare
arturjanc
approved these changes
Mar 5, 2020
|
I think this has been incorporated into other CLs? LGTM after rebase if not. :) |
mikewest
approved these changes
Apr 20, 2020
|
Do you need anything more from me here? I want to make sure I'm not blocking your progress on whatwg/html#5454. :) |
Change "CORP" to "corp", so as to be consistent with other values. Pointed out at: https://crrev.com/c/2076223/11/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/reporting.https.html
yutakahirano
force-pushed
the
yhirano/reporting-feedback
branch
from
1524220 to
606c55b
Compare
|
Sorry, there's no external blocker. I hope I'll have more time after the branch point. |
|
And thank you for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change "CORP" to "corp", so as to be consistent with other values.
Pointed out at:
https://crrev.com/c/2076223/11/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/reporting.https.html