Allow OS registration headers to specify multiple URLs #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharrison
approved these changes
May 5, 2023
This does not add any new functionality to the API, as reporting origins could already redirect to another URL under their control in order to perform multiple registrations, but does obviate that bandwidth-wasting anti-pattern.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 9, 2023
WICG/attribution-reporting-api#780 To reduce the scope of this change, we handle the list of URLs iteratively, rather than passing the list around as one unit. We can investigate changing this in a followup CL in order to decrease the number of Mojo and JNI calls. Bug: 1442901 Change-Id: I7b942eec139a38c29f6e8539ffb5a332d75a4eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507802 Reviewed-by: Nan Lin <linnan@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1141322}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not add any new functionality to the API, as reporting origins could already redirect to another URL under their control in order to perform multiple registrations, but does obviate that bandwidth-wasting anti-pattern.
Fixes #696
Preview | Diff