Skip to content

Commit

Permalink
Probe Offset Wizard followupBack to PROBE_PT_RAISE/separate STOW, mak…
Browse files Browse the repository at this point in the history
…e "PROBING" msg appear (MarlinFirmware#20439)

* Go back to always use PROBE_PT_RAISE with a discrete stow. This ensures a raise above the bed, while stowing prior to exiting the wizard.
* Fix issue preventing text while moving to X/Y position
Co-authored-by: FanDjango <FanDjango@users.noreply.github.com>
  • Loading branch information
FanDjango authored and W4tel-BiDi committed Apr 5, 2021
1 parent c44240a commit c38037e
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions Marlin/src/lcd/menu/menu_probe_offset.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,11 @@ void probe_offset_wizard_menu() {
}

void prepare_for_probe_offset_wizard() {
if (ui.wait_for_move) return;

#if defined(PROBE_OFFSET_WIZARD_XY_POS) || !HOMING_Z_WITH_PROBE
if (ui.should_draw()) MenuItem_static::draw(1, GET_TEXT(MSG_PROBE_WIZARD_PROBING));

if (ui.wait_for_move) return;

#ifndef PROBE_OFFSET_WIZARD_XY_POS
#define PROBE_OFFSET_WIZARD_XY_POS XY_CENTER
#endif
Expand All @@ -133,20 +133,25 @@ void prepare_for_probe_offset_wizard() {

// Probe for Z reference
ui.wait_for_move = true;
z_offset_ref = probe.probe_at_point(wizard_pos, PROBE_PT_STOW, 0, true);
z_offset_ref = probe.probe_at_point(wizard_pos, PROBE_PT_RAISE, 0, true);
ui.wait_for_move = false;

// Stow the probe, as the last call to probe.probe_at_point(...) left
// the probe deployed if it was successful.
probe.stow();
#else
if (ui.wait_for_move) return;
#endif

SET_SOFT_ENDSTOP_LOOSE(true); // Disable soft endstops for free Z movement

// Move Nozzle to Probing/Homing Position
ui.wait_for_move = true;
current_position += probe.offset_xy;
line_to_current_position(MMM_TO_MMS(HOMING_FEEDRATE_XY));
ui.synchronize(GET_TEXT(MSG_PROBE_WIZARD_MOVING));
ui.wait_for_move = false;

SET_SOFT_ENDSTOP_LOOSE(true); // Disable soft endstops for free Z movement

// Go to Calibration Menu
ui.goto_screen(probe_offset_wizard_menu);
ui.defer_status_screen();
Expand Down

0 comments on commit c38037e

Please sign in to comment.