fix: Update VcPkg to fix issue when installing Zlib #4677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
changed the title
* Updates vcpkg to release tag 2023.12.12 * Changes build windows cmake to be manually-triggered only * Ignore default folder vcpkg will install to when triggered from CLI
lokitoth
force-pushed
the
fix_vcpkg_zlib
branch
from
30400e0
to
2afb825
Compare
|
Force-push to fix semantic-title check |
|
Closing, since this is a duplicate (ish, later vcpkg version) of #4672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current VcPkg version's port of zlib relies on a msys2 dependency to be downloaded from the web (in this case libwinpthreads), which now errors out with 404. This has not been caught by CI because we cache vcpkg artifacts to avoid a very long build-time. The fix is to upgrade vcpkg to a newer version.
Changes:
In addition: We should consider adding a vcpkg-only test action on a schedule (or similar) to ensure that we catch these