Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete new_version script #2932

Merged
merged 1 commit into from
Apr 9, 2021
Merged

chore: Delete new_version script #2932

merged 1 commit into from
Apr 9, 2021

Conversation

jackgerrits
Copy link
Member

Delete the new_version script as it is not used in the release process at the moment and does not update all locations and so is misleading.

Closes: #1714

@olgavrou olgavrou merged commit 8075dfd into master Apr 9, 2021
@jackgerrits jackgerrits deleted the jackgerrits-patch-7 branch April 12, 2021 15:05
nandahkrishna pushed a commit to olgavrou/homebrew-core that referenced this pull request Jul 14, 2021
Also remove `rm new_version`, since it was removed in
VowpalWabbit/vowpal_wabbit#2932.
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 14, 2021
Also remove `rm new_version`, since it was removed in
VowpalWabbit/vowpal_wabbit#2932.

Closes #81257.

Signed-off-by: Nanda H Krishna <me@nandahkrishna.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update new_version script to update version.txt and other instances of version number
2 participants