add to more CIs

VowpalWabbit · Jun 3, 2024 · 57b7257 · 57b7257
1 parent 37b7ba2
commit 57b7257
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/asan.yml b/.github/workflows/asan.yml
@@ -54,6 +54,7 @@ jobs:
       - uses: lukka/run-cmake@v10
         env:
           VCPKG_ROOT: ${{github.workspace}}/ext_libs/vcpkg
+          CMAKE_ARGS: "-DSTD_INV_SQRT=ON"
         with:
           cmakeListsTxtPath: "${{ github.workspace }}/CMakeLists.txt"
           configurePreset: "${{ matrix.preset }}"

diff --git a/.github/workflows/build_macos.yml b/.github/workflows/build_macos.yml
@@ -27,7 +27,7 @@ jobs:
       - name: Install dependencies
         run: brew install cmake boost flatbuffers ninja
       - name: Configure
-        run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=${{matrix.build_type}} -DWARNINGS=Off -DVW_BUILD_VW_C_WRAPPER=Off -DBUILD_TESTING=On -DBUILD_EXPERIMENTAL_BINDING=On -DVW_FEAT_CSV=On -DVW_FEAT_CB_GRAPH_FEEDBACK=On -DVW_INSTALL=Off
+        run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=${{matrix.build_type}} -DWARNINGS=Off -DVW_BUILD_VW_C_WRAPPER=Off -DBUILD_TESTING=On -DBUILD_EXPERIMENTAL_BINDING=On -DVW_FEAT_CSV=On -DVW_FEAT_CB_GRAPH_FEEDBACK=On -DVW_INSTALL=Off -DSTD_INV_SQRT=ON
       - name: Build
         run: cmake --build build --target all
       - name: Unit tests

diff --git a/.github/workflows/python_wheels.yml b/.github/workflows/python_wheels.yml
@@ -43,7 +43,7 @@ jobs:
       - name: Build wheel
         shell: bash
         run: |
-          ${{ matrix.config.base_path }}bin/pip wheel . -w wheel_output/ --global-option --cmake-options="-DSTATIC_LINK_VW_JAVA=On;-DPython_INCLUDE_DIR='${{ matrix.config.base_path }}include/${{ matrix.config.include_dir_name }}'" --verbose
+          ${{ matrix.config.base_path }}bin/pip wheel . -w wheel_output/ --global-option --cmake-options="-DSTATIC_LINK_VW_JAVA=On -DSTD_INV_SQRT=ON;-DPython_INCLUDE_DIR='${{ matrix.config.base_path }}include/${{ matrix.config.include_dir_name }}'" --verbose
           auditwheel repair wheel_output/*whl -w audit_output/
       - name: Upload built wheel
         uses: actions/upload-artifact@v1

diff --git a/.github/workflows/vendor_build.yml b/.github/workflows/vendor_build.yml
@@ -86,6 +86,7 @@ jobs:
           -DVW_ZLIB_SYS_DEP=Off
           -DVW_BOOST_MATH_SYS_DEP=Off
           -DVW_INSTALL=Off
+          -DSTD_INV_SQRT=ON
       - name: Build
         run: cmake --build "${{ env.CMAKE_BUILD_DIR }}" --config ${{ matrix.build_type }}
       - name: Test run_tests.py