Skip to content

Commit

Permalink
refactor: add api to set data object associated with learner (#4523)
Browse files Browse the repository at this point in the history
* refactor: add api to set data object associated with learner

* add shared ptr func
  • Loading branch information
jackgerrits authored Mar 9, 2023
1 parent b622540 commit 2238d70
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions vowpalwabbit/core/include/vw/core/learner.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,16 @@ class learner final : public std::enable_shared_from_this<learner>

void* get_internal_type_erased_data_pointer_test_use_only() { return _learner_data.get(); }

std::shared_ptr<void> get_internal_type_erased_data_pointer_test_use_only_shared() { return _learner_data; }

// This is very dangerous to use.
// This will not override the data object passed to functions, just the data object returned by
// get_internal_type_erased_data_pointer_test_use_only
void set_internal_type_erased_data_pointer_does_not_override_funcs(std::shared_ptr<void> data)
{
_learner_data = std::move(data);
}

/// \brief Will update the model according to the labels and examples supplied.
/// \param ec The ::example object or ::multi_ex to be operated on. This
/// object **must** have a valid label set for every ::example in the field
Expand Down

0 comments on commit 2238d70

Please sign in to comment.