Skip to content

Commit

Permalink
fix: Build break on Ubuntu 2004
Browse files Browse the repository at this point in the history
The C++ compiler on our image of Ubuntu 2004 cannot properly pick up Offset<> => Offset<void>. Make this explicit.
  • Loading branch information
lokitoth committed Feb 14, 2024
1 parent b7c7748 commit 1895dcc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vowpalwabbit/fb_parser/tests/read_span_tests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ Offset<fb::Example> create_bad_ns_root_example(FlatBufferBuilder& builder, VW::w
{
std::vector<Offset<fb::Namespace>> namespaces = { ns_fac(builder, w) };

Offset<> label_offset = fb::Createno_label(builder).Union();
Offset<void> label_offset = fb::Createno_label(builder).Union();
return fb::CreateExample(builder, builder.CreateVector(namespaces), fb::Label_no_label, label_offset);
}

Expand Down Expand Up @@ -185,7 +185,7 @@ template <int error_code, typename FB_t, fb::ExampleType root_type>
void create_flatbuffer_span_and_expect_error(VW::workspace& w, namespace_factory_f ns_fac, builder_f<FB_t> root_builder)
{
FlatBufferBuilder builder;
Offset<> data_obj = root_builder(builder, w, ns_fac).Union();
Offset<void> data_obj = root_builder(builder, w, ns_fac).Union();

Offset<fb::ExampleRoot> root_obj = fb::CreateExampleRoot(builder, root_type, data_obj);

Expand Down

0 comments on commit 1895dcc

Please sign in to comment.