feat: static model loader #603
Conversation
| } | ||
|
|
||
| char* buffer = data.alloc(this->len); | ||
| if (buffer == nullptr) { return reinforcement_learning::error_code::static_model_load_error; } |
There was a problem hiding this comment.
Wondering if model_data class can use a method to encapsulate these operations. i.e. alloc + copy + set size
There was a problem hiding this comment.
put a set_data function in data_data to handle this
| new New<FactoryContext>(() => { | ||
| var vwModelArray = vwModelEnumerable.ToArray(); | ||
| GCHandle handle = GCHandle.Alloc(vwModelArray, GCHandleType.Pinned); | ||
| try { |
There was a problem hiding this comment.
Is there a way to check if this makes a copy here? Unclear to me...
CreateFactoryContextWithStaticModel does make a copy. Wondering if there are 2 copies happening.
There was a problem hiding this comment.
There is a copy happening here but I believe it is necessary since they pass in a List which doesn't have a way to obtain a pointer to it's internal array
There was a problem hiding this comment.
There is a way to avoid the copy on .NET 5 or above with List<> types, but not generally, no.
No description provided.