Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update vw sparse fixes #589

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix: update vw sparse fixes #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1da74c2
update vw sparse fixes
bassmang Sep 29, 2023
4ef0aaf
Merge branch 'master' into rl_latest
bassmang Sep 29, 2023
21ff505
reflect cats learn_returns_prediction
bassmang Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext_libs/vowpal_wabbit
Open in desktop
Submodule vowpal_wabbit updated 37 files
+2 −1 cs/unittest/RunTests.tt
+41 −0 test/core.vwtest.json
+57 −57 test/pred-sets/ref/cats.predict
+10 −10 test/pred-sets/ref/cats_load.predict
+100 −100 test/pred-sets/ref/cats_room_temp.predict
+5 −5 test/pred-sets/ref/cats_save.predict
+11 −11 test/pred-sets/ref/ftrl_coin.predict
+1 −0 test/pred-sets/ref/single_empty_lines.predict
+23 −0 test/test-sets/ref/single_empty_lines.stderr
+0 −0 test/test-sets/ref/single_empty_lines.stdout
+6 −6 test/train-sets/ref/0001-replay.stderr
+7 −7 test/train-sets/ref/cats-predict.stderr
+7 −7 test/train-sets/ref/cats-train.stderr
+4 −4 test/train-sets/ref/cats_load.stderr
+8 −8 test/train-sets/ref/cats_room_temp.stderr
+8 −8 test/train-sets/ref/cats_room_temp_pred.stderr
+4 −4 test/train-sets/ref/cats_save.stderr
+3 −4 test/train-sets/ref/empty-set.stderr
+7 −7 test/train-sets/ref/ftrl_coin.stderr
+22 −0 test/train-sets/ref/sparse_load_check.stderr
+0 −0 test/train-sets/ref/sparse_load_check.stdout
+23 −0 test/train-sets/ref/sparse_save_check.stderr
+0 −0 test/train-sets/ref/sparse_save_check.stdout
+11 −12 test/train-sets/ref/topk-train.stderr
+9 −0 test/train-sets/single_empty_lines.txt
+3 −3 vowpalwabbit/core/include/vw/core/array_parameters_sparse.h
+2 −0 vowpalwabbit/core/include/vw/core/example.h
+46 −0 vowpalwabbit/core/src/example.cc
+7 −0 vowpalwabbit/core/src/global_data.cc
+1 −0 vowpalwabbit/core/src/learner.cc
+1 −1 vowpalwabbit/core/src/reduction_stack.cc
+3 −15 vowpalwabbit/core/src/reductions/boosting.cc
+3 −0 vowpalwabbit/core/src/reductions/cats.cc
+2 −2 vowpalwabbit/core/src/reductions/ftrl.cc
+36 −30 vowpalwabbit/core/src/reductions/interaction_ground.cc
+16 −1 vowpalwabbit/core/src/vw_validate.cc
+40 −0 wasm/documentation.md
2 changes: 1 addition & 1 deletion external_parser/unit_tests/test_metrics.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ BOOST_AUTO_TEST_CASE(check_metrics_ca_mixed_deferred_action_events)
std::string infile_name = "valid_joined_logs/ca_mixed_deferred_action_events_20.log";
std::string outfile_name = "ca_mixed_deferred_action_events.json";

std::map<std::string, int> expected_int_metrics = {{"total_predict_calls", 10}, {"total_learn_calls", 10},
std::map<std::string, int> expected_int_metrics = {{"total_predict_calls", 0}, {"total_learn_calls", 10},
{"number_skipped_events", 10}, {"number_events_zero_actions", 0}, {"line_parse_error", 0}};

std::map<std::string, float> expected_float_metrics = {
Expand Down
Loading