Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser] Update to latest schema and add large file goodies. #288

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kumpera
Copy link
Contributor

@kumpera kumpera commented Apr 6, 2021

The two large file improvements are: --short and --summary.

--short: produce a one line message per event.
--summary: print one line per checkpoint message.

The two large file improvements are: `--short` and `--summary`.

`--short`: produce a one line message per event.
`--summary`: print one line per checkpoint message.
Copy link
Collaborator

@olgavrou olgavrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have the joiner.py produce checkpoints or is that something we will skip?

Copy link
Collaborator

@olgavrou olgavrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah just noticed that REWARD_FUNCTION is the equivalent of MSG_TYPE_CHECKPOINT

@cheng-tan
Copy link
Collaborator

Do we want to have the joiner.py produce checkpoints or is that something we will skip?

I'm updating RewardFunctionInfo to CheckpointInfo and add in the config of learning mode and problem type. I can update the joiner.py, it will be needed for the unit test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants