Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro 0.7 fix #305

Merged
merged 22 commits into from
Jun 26, 2023
Merged

Macro 0.7 fix #305

merged 22 commits into from
Jun 26, 2023

Conversation

nemgrea
Copy link
Contributor

@nemgrea nemgrea commented Jun 26, 2023

No description provided.

@nemgrea nemgrea mentioned this pull request Jun 26, 2023
Closed
KiloQubit
KiloQubit requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@KiloQubit KiloQubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename

HOME_CURRENT to HOME_ CURRENT_RATIO to avoid confusion, since it's not actually the current any more, like RUN_CURRENT is.

Also 'current' is misspelled in all files:

by default we are dropping the motor currnet

@nemgrea
Copy link
Contributor Author

nemgrea commented Jun 26, 2023

fixed

@KiloQubit KiloQubit merged commit 03c1a5c into VoronDesign:Voron0.2r1 Jun 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiloQubit KiloQubit KiloQubit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nemgrea @KiloQubit