Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove magic-logger #61

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat: Remove magic-logger #61

merged 1 commit into from
Jul 20, 2023

Conversation

joloppo
Copy link
Contributor

@joloppo joloppo commented Jul 20, 2023

Tests pass. Removes magic-logger module. Package logging should not affect application level logging.

Copy link
Contributor

@matteo-pallini matteo-pallini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joloppo joloppo merged commit 1d3588f into v5 Jul 20, 2023
@arturk-vortexa arturk-vortexa mentioned this pull request Aug 4, 2023
@joloppo joloppo deleted the v5-logging branch September 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants