VIDCS-3286: Auto-set Base Branch to Develop #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maikthomas
reviewed
Jan 24, 2025
.github/workflows/auto-set-base.yml
Outdated
Comment on lines
14
to
23
| - name: Check and Update Base Branch | ||
| run: | | ||
| if [ "${{ github.event.pull_request.base.ref }}" != "develop" ]; then | ||
| gh pr edit ${{ github.event.pull_request.number }} --base develop | ||
| echo "Base branch updated to 'develop'."; | ||
| else | ||
| echo "Base branch is already 'develop'."; | ||
| fi | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Not a common case, but I think this should only happen if the target branch is main
There was a problem hiding this comment.
Hmm makes sense!! Doing that.
maikthomas
reviewed
Jan 24, 2025
.github/workflows/auto-set-base.yml
Outdated
|
|
||
| - name: Check and Update Base Branch | ||
| run: | | ||
| if [ "${{ github.event.pull_request.base.ref }}" == "main" ]; then |
There was a problem hiding this comment.
We should have the logic be
if TARGET_BRANCH == main && BASE_BRANCH != develop
switch to develop
maikthomas
approved these changes
Jan 24, 2025
behei-vonage
approved these changes
Jan 24, 2025
dwivedisachin
deleted the
VIDCS-3286-change-pr-default-base-to-develop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR adds a GHA job to make develop as the base branch of the PR only on opening the PR. Which will acts as the default moving forward.
Also, we can re-change the default branch once the job is done to whatever we want.
How should this be manually tested?
Notice below the default of this branch is changed to develop by bot
Logs to the job before the last commit to make it run only on opening the PR
What are the relevant tickets?
Resolves VIDCS-3286
[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?
[ ] If yes, did you close the item in
Issues?