Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDCS-3281: Skip Sonarcloud scan and Integration tests if PR is from a fork (External Contributor) #25

Conversation

dwivedisachin
Copy link
Collaborator

@dwivedisachin dwivedisachin commented Jan 23, 2025

What is this PR doing?

Skip Sonarcloud scan and Integration tests if PR is from a fork (External)

How should this be manually tested?

I added this change to this PR which I created from my personal test github account (a an external contributor).
And the jobs are getting skipped
Which I believe should be enough testing for the PR

What are the relevant tickets?

Resolves VIDCS-3281

[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?
[ ] If yes, did you close the item in Issues?

@dwivedisachin dwivedisachin added the WIP Work in progress label Jan 23, 2025
@dwivedisachin dwivedisachin changed the title VIDCS-3281: Skip Sonarcloud scan and Integration tests if PR is from a fork (External) VIDCS-3281: Skip Sonarcloud scan and Integration tests if PR is from a fork (External Contributor) Jan 23, 2025
@dwivedisachin dwivedisachin added do-not-merge Do Not Merge and removed WIP Work in progress labels Jan 23, 2025
@dwivedisachin dwivedisachin changed the base branch from main to develop January 24, 2025 10:21
@dwivedisachin dwivedisachin removed the do-not-merge Do Not Merge label Jan 24, 2025
Copy link
Collaborator

@maikthomas maikthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dwivedisachin dwivedisachin merged commit 7c385b2 into develop Jan 24, 2025
6 checks passed
@dwivedisachin dwivedisachin deleted the VIDCS-3281-skip-sonar-integration-tests-for-external-contributors branch January 24, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants