Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: OLD Bots queries all bots and fails to use address of the wallet for query #1295

Closed
taariq opened this issue Feb 20, 2024 · 1 comment
Closed

BUG: OLD Bots queries all bots and fails to use address of the wallet for query #1295

taariq opened this issue Feb 20, 2024 · 1 comment
Assignees
@jamie088
Labels
curvebot PalomaBot

Comments

@taariq
Copy link
Member

taariq commented Feb 20, 2024 •
edited
Loading

Old Bots Query

  1. The Front End is calling https://service.palomabot.ai/robots?completed=true without a wallet address that means it'll find every completed robot and then do looks up on all their coins.. etc..
  2. The Front-End times out because thats a lot of lookups
  3. The front end should be using an address so it only finds the wallets completed transactions.
  4. This will fix the error: Failed to load resource: the server responded with a status of 504 (Gateway Time-out) https://service.palomabot.ai/robots?completed=true
@jamie088
Copy link

Fixed with https://github.com/VolumeFi/palomabot/pull/376.

@taariq taariq closed this as completed Feb 20, 2024
@taariq taariq mentioned this issue Feb 20, 2024
Closed
@verabehr verabehr mentioned this issue Feb 22, 2024
Closed
taariq pushed a commit that referenced this issue Sep 20, 2024
@maharifu
fix: decrease success rate if validator fails to relay (#1295)
a5377d2 
# Related Github tickets

- Closes #2173

# Background

Currently if the assigned validator fails to relay a message it is
simply removed from the queue and does not count as a failure to the
assigned validator. This means if a validator is incapable or unwilling
to relay messages, it's success rate metric never changes.

When removing messages from the queue, we check if it was relayed (it
has public or error data). If it does not, then we consider it a failure
and update the validator metrics.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamie088 jamie088

Labels
curvebot PalomaBot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taariq @jamie088