Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Euro Offramp Bot shows WRONG TVL on processing. See the pic #1292

Closed
taariq opened this issue Feb 19, 2024 · 1 comment
Closed

BUG: Euro Offramp Bot shows WRONG TVL on processing. See the pic #1292

taariq opened this issue Feb 19, 2024 · 1 comment
Assignees
@rootedbox
Labels
bug Something isn't working curvebot PalomaBot

Comments

@taariq
Copy link
Member

taariq commented Feb 19, 2024 •
edited
Loading

BUG: Euro Offramp Bot shows WRONG TVL on processing. See the pic.

Transaction: https://etherscan.io/tx/0xf27c8e9159252e8dcd078cc9e29f667f8fda037d950d5f69de21385f6036a74c

Image
@taariq taariq added bug Something isn't working PalomaBot curvebot labels Feb 19, 2024
@taariq taariq assigned rootedbox and unassigned jamie088 Feb 19, 2024
@taariq
Copy link
Member Author

taariq commented Feb 20, 2024

Fixed with https://github.com/VolumeFi/bot-info-api/pull/66

@taariq taariq closed this as completed Feb 20, 2024
maharifu added a commit that referenced this issue Sep 13, 2024
@maharifu
chore: update validator nonces in endblocker (#1292)
d4d89dd 
# Related Github tickets

- #2160

# Background

The way it was before, we would need a claim to be observed so
validators would be updated. By doing it in the endblocker, we
validators are always up-to-date.

This should prevent a situation where the last claim is 19, the last
observed nonce is 18, but validators are stuck on nonce 17. They would
receive a list of block events with the block of nonce 19 (latest
unobserved) but would be unable to claim it, since skyway would expect
them to submit a claim for nonce 18 instead.

# Testing completed

- [ ] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootedbox rootedbox

Labels
bug Something isn't working curvebot PalomaBot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@taariq @rootedbox @jamie088