Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Leverage Bot Returning Too Many Requests Error. Solution: Move decimals to mybots API #1279

Closed
3 tasks done
taariq opened this issue Feb 14, 2024 · 2 comments
Closed
3 tasks done
Assignees
Labels
bug Something isn't working curvebot

Comments

@taariq
Copy link
Member

taariq commented Feb 14, 2024

POST https://eth-protect.rpc.blxrbdn.com/ 429 (Too Many Requests).

@rootedbox
Will we please stop hammering on the endpoints from the front-end?

Done when

  • add decimals of the token0 and token1 are added to mybots api in the coin info (@rootedbox ) Coingecko returns this in the GET coins/{id} endpoint
"coin_info":{"id":"crvusd","symbol":"crvusd","name":"crvUSD","platforms":{"ethereum":"0xf939e0a03fb07f59a73314e73794be0e57ac1b4e","polygon-pos":"0xc4ce1d6f5d98d65ee25cf85e9f2e9dcfee6cb5d6","xdai":"0xabef652195f98a91e490f047a5006b71c85f058d","base":"0x417ac0e078398c154edfadd9ef675d30be60af93","optimistic-ethereum":"0xc52d7f23a2e460248db6ee192cb23dd12bddcbf6","arbitrum-one":"0x498bf2b1e120fed3ad3d42ea2165e9b73f99c1e5"},"image":{"large":"https://assets.coingecko.com/coins/images/30118/large/crvusd.jpeg?1683171990","small":"https://assets.coingecko.com/coins/images/30118/small/crvusd.jpeg?1683171990","thumb":"https://assets.coingecko.com/coins/images/30118/thumb/crvusd.jpeg?1683171990"}}
  • the withdraw timestamp is added (converted from withdraw block) in mybots api (@rootedbox )
  • the FE API calls are reduced after API update (@jamie088 )
@taariq taariq added bug Something isn't working curvebot labels Feb 14, 2024
@verabehr verabehr assigned jamie088 and unassigned rootedbox Feb 14, 2024
@verabehr
Copy link

@jamie088 I believe this is an FE issue. Will you check on this one?

@taariq
Copy link
Member Author

taariq commented Feb 14, 2024

@jamie088 I have looked at noticed the following:

  1. It appeas that Paloma makes 150 requests on the Mybot page for MY Account
  2. CORS errors begin after about 200 requests are made. Why do we need to request 150 times on page load?
  3. It appears that we are being offloaded to a secondary server that does not have CORS setup for Bloxroute. I'll inform the bloxroute team. However, we need to fix why we are making so many requests from the endpoint provider, See picture

Image

@taariq taariq changed the title BUG: Leverage Bot Returning Too Many Requests Error. BUG: Leverage Bot Returning Too Many Requests Error. Solution: Move decimals to mybots API Feb 14, 2024
byte-bandit added a commit that referenced this issue Aug 30, 2024
# Related Github tickets

- #1960
- #1951
- #1956
- #2043

# Background

This change makes use of the atomic handover endpoint on compass,
re-enables the token relink and ensures ownership of fee manager is
transferred as well.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working curvebot
Projects
None yet
Development

No branches or pull requests

4 participants