fix: set upper bound for required poetry-core version #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erny-powel
approved these changes
Jan 7, 2025
tnoczyns-volue
deleted the
tnoczyns-2025-01-07-fix-package-installation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the steps to address #526
With poetry-core 2.0.0 there was a breaking change introduced:
https://python-poetry.org/blog/announcing-poetry-2.0.0#consistent-include-behavior
This affected the way we included generated python proto stubs. Namely by default if a VCS is used by default ignored files will be excluded. To avoid this we need to explicitly set needed files in
includesection. Include has higher priority than exclude rules.For more info see: https://python-poetry.org/docs/pyproject#exclude-and-include
However, until now we didn't use
formatoption. With poetry-core 2.0.0 if format is not specified the file is only included in sdist, previously it was sdist and wheel.This PR makes the include section poetry-core 2.0.0 compatible, but also limits the max poetry-core version (< 2.0.0) to avoid similar compatibility surprises in the future.
Additionally, I set the minimum poetry-core version to 1.8.5 as 1.9.x are not included in pipx.