Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HydSim: use CaseGroup/Case to reference simulations #398

Closed
erny-powel opened this issue Jan 22, 2024 · 0 comments · Fixed by #399
Closed

HydSim: use CaseGroup/Case to reference simulations #398

erny-powel opened this issue Jan 22, 2024 · 0 comments · Fixed by #399
Assignees
@erny-powel
Labels
Kind: Enhancement Enchancement of existing features or functionality

Comments

@erny-powel
Copy link
Collaborator

See discussion from https://github.com/Volue/energy-sim/issues/742#issuecomment-1811942095.
@erny-powel erny-powel added the Kind: Enhancement Enchancement of existing features or functionality label Jan 22, 2024
@erny-powel erny-powel self-assigned this Jan 22, 2024
erny-powel added a commit that referenced this issue Jan 22, 2024
@erny-powel
Use CaseGroup/CaseName to refer to hydsim cases
ede9137 
`CaseGroup/CaseName` is established syntax used in various UIs, Optimal
Gateway, and Automation Framework. As discussed in
Volue/energy-sim#742 (comment).

There's an argument for more user friendly error handling here, but I
think this is API compatible with a future improvement, and I want to
get this API break done ASAP. For now you'll get a `ValueError` if the
split doesn't split.

Closes #398.
@erny-powel erny-powel mentioned this issue Jan 22, 2024
Merged
erny-powel added a commit that referenced this issue Jan 22, 2024
@erny-powel
Use CaseGroup/CaseName to refer to hydsim cases
d4e0507 
`CaseGroup/CaseName` is established syntax used in various UIs, Optimal
Gateway, and Automation Framework. As discussed in
Volue/energy-sim#742 (comment).

There's an argument for more user friendly error handling here, but I
think this is API compatible with a future improvement, and I want to
get this API break done ASAP. For now you'll get a `ValueError` if the
split doesn't split.

Closes #398.
erny-powel added a commit that referenced this issue Jan 22, 2024
@erny-powel
Use CaseGroup/CaseName to refer to hydsim cases
168ec15 
`CaseGroup/CaseName` is established syntax used in various UIs, Optimal
Gateway, and Automation Framework. As discussed in
Volue/energy-sim#742 (comment).

There's an argument for more user friendly error handling here, but I
think this is API compatible with a future improvement, and I want to
get this API break done ASAP. For now you'll get a `ValueError` if the
split doesn't split.

Closes #398.
erny-powel added a commit that referenced this issue Jan 22, 2024
@erny-powel
Use CaseGroup/CaseName to refer to hydsim cases (#399)
b55501e 
`CaseGroup/CaseName` is established syntax used in various UIs, Optimal
Gateway, and Automation Framework. As discussed in
Volue/energy-sim#742 (comment).

There's an argument for more user friendly error handling here, but I
think this is API compatible with a future improvement, and I want to
get this API break done ASAP. For now you'll get a `ValueError` if the
split doesn't split.

Closes #398.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erny-powel erny-powel

Labels
Kind: Enhancement Enchancement of existing features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use CaseGroup/CaseName to refer to hydsim cases Volue-Public/energy-mesh-python
1 participant
@erny-powel