Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Scrollbar from Grafana UI #251

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vitPinchuk
Copy link
Contributor

Resolves #219

@vitPinchuk vitPinchuk added enhancement New feature or request enterprise Business Suite Enterprise labels Feb 14, 2025
@vitPinchuk vitPinchuk added this to the Table 2.3.0 milestone Feb 14, 2025
@vitPinchuk vitPinchuk self-assigned this Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.64%. Comparing base (4dbd23d) to head (de8f34a).

Files with missing lines Patch % Lines
src/components/TablePanel/TablePanel.tsx 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         203      203           
  Lines        3372     3378    +6     
  Branches      790      767   -23     
=======================================
+ Hits         3360     3366    +6     
- Misses         11       12    +1     
+ Partials        1        0    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitPinchuk Please resolve conflicts.

@vitPinchuk
Copy link
Contributor Author

@mikhail-vl All conflicts are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request enterprise Business Suite Enterprise
Projects
Status: Ready
Development

Successfully merging this pull request may close these issues.

Use Custom Scrollbar from Grafana UI
4 participants