Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/liquid gradient #3034

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Fix/liquid gradient #3034

merged 6 commits into from
Aug 5, 2024

Conversation

skie1997
Copy link
Contributor

@skie1997 skie1997 commented Aug 2, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

🐞 Bugserver case id

66ac7bac27f96000ad549ef6
66ac7a5327f96000ad549ef5

💡 Background and solution

  1. 水波图渐变色bug问题修复
    解决方案: 在glyph外再套一层group,通过group属性设置glyph位置
    修改前:
    image

修改后:
image

  1. 水波图maskShape为rect时,symbol类型的rect宽高比始终为2:1,导致增加padding时,上下间距和左右间距无法保持一致
    解决方案:maskShape为‘rect’时,使用rect图元而非symbol图元

修改前:
image

修改后:
image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@xile611 xile611 merged commit 6deb96c into develop Aug 5, 2024
4 of 6 checks passed
@xile611 xile611 deleted the fix/liquid-gradient branch August 5, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants